Skip to content

fix: remove memory leak iterative_factorial.cpp#2535

Merged
realstealthninja merged 2 commits intoTheAlgorithms:masterfrom
vil02:memory_leak_iterative_factorial_patch
Aug 30, 2024
Merged

fix: remove memory leak iterative_factorial.cpp#2535
realstealthninja merged 2 commits intoTheAlgorithms:masterfrom
vil02:memory_leak_iterative_factorial_patch

Conversation

@vil02
Copy link
Copy Markdown
Member

@vil02 vil02 commented Sep 18, 2023

Description of Change

There is a memory leak in iterative_factorial.cpp while throwing an exception. This PR fixes it and does some other small changes.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
Removes memory leak in iterative_factorial.cpp.

@vil02 vil02 marked this pull request as ready for review September 18, 2023 16:28
CarlosZoft
CarlosZoft reviewed Sep 22, 2023
View reviewed changes
Comment thread math/iterative_factorial.cpp Outdated
@vil02 vil02 requested a review from CarlosZoft September 22, 2023 14:24
@CarlosZoft
Copy link
Copy Markdown
Member

CarlosZoft commented Oct 2, 2023

@vil02, some suggestions.. pls resolve the conflits

image

@vil02 vil02 force-pushed the memory_leak_iterative_factorial_patch branch from 4fe4cf4 to e4ada59 Compare October 2, 2023 11:43
@vil02
Copy link
Copy Markdown
Member Author

vil02 commented Oct 2, 2023

@vil02, some suggestions.. pls resolve the conflits

image

@CarlosZoft luckily there were no conflicts, just my branch was out-of-date. It is fixed now.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 24, 2023

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale Author has not responded to the comments for over 2 weeks label Dec 24, 2023
@vil02
Copy link
Copy Markdown
Member Author

vil02 commented Dec 24, 2023

@Panquesito7, @realstealthninja: Merry Christmas and please dont-close.

@github-actions github-actions Bot removed the stale Author has not responded to the comments for over 2 weeks label Dec 25, 2023
@vil02 vil02 force-pushed the memory_leak_iterative_factorial_patch branch from e4ada59 to a86a017 Compare January 16, 2024 07:11
@vil02 vil02 force-pushed the memory_leak_iterative_factorial_patch branch from a86a017 to 443d2ff Compare February 12, 2024 21:13
realstealthninja
realstealthninja approved these changes Mar 11, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 11, 2024

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale Author has not responded to the comments for over 2 weeks label Apr 11, 2024
@vil02
Copy link
Copy Markdown
Member Author

vil02 commented Apr 11, 2024

Please add dont-close or merge.

CarlosZoft
CarlosZoft approved these changes Apr 16, 2024
View reviewed changes
Comment thread math/iterative_factorial.cpp
Comment thread math/iterative_factorial.cpp
Comment thread math/iterative_factorial.cpp
@github-actions github-actions Bot removed the stale Author has not responded to the comments for over 2 weeks label Jul 26, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 25, 2024

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale Author has not responded to the comments for over 2 weeks label Aug 25, 2024
@vil02
Copy link
Copy Markdown
Member Author

vil02 commented Aug 28, 2024

Please add dont-close or merge.

I still think this PR is valuable.

@realstealthninja
Copy link
Copy Markdown
Collaborator

realstealthninja commented Aug 28, 2024

@vil02 no more don't closing cause I'm merging it

@realstealthninja realstealthninja added dont-close This issue/pull request shouldn't be closed and removed stale Author has not responded to the comments for over 2 weeks labels Aug 28, 2024
@realstealthninja realstealthninja merged commit 8a36824 into TheAlgorithms:master Aug 30, 2024
@vil02 vil02 deleted the memory_leak_iterative_factorial_patch branch August 30, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@realstealthninja realstealthninja realstealthninja approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

+1 more reviewer

@CarlosZoft CarlosZoft CarlosZoft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dont-close This issue/pull request shouldn't be closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vil02 @CarlosZoft @realstealthninja